+semver:major Added properties to ArchivingDlgViewModel to facilitate customizing the initial summary #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahn-kev
reviewed
Oct 7, 2024
tombogle
changed the title
tombogle
force-pushed
the
archiving-api-improvements
branch
from
b75a621 to
b208966
Compare
… customizing the initial summary Added unit tests and changed test app to illustrate intended usage of the new properties. Improved/added some comments in ArchivingDlgViewModel
…ach of multiple multiple pre-archiving messages
TEMP: Added some console.log statements to try to see what's happening with TC tests
tombogle
force-pushed
the
archiving-api-improvements
branch
from
776fa1a to
680d783
Compare
tombogle
changed the title
|
I think it is a technically a major version number change because I renamed a parameter. In most cases, it will recompile with no actual code changes, but if a caller were to use named parameters, then it could break. (Originally, I had intended to remove a method as well, but I decided to leave it.) In any case, this is already going to be included in a release that will cause a bump in the major version number. |
hahn-kev
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests and changed test app to illustrate intended usage of the new properties. Improved/added some comments in ArchivingDlgViewModel
Note: I considered removing OverrideDisplayInitialSummary because with this change, I anticipate that it will no longer be needed, but since it is inexpensive to leave in and allows for maximum flexibility, I decided to leave it.
This change is